Re: [PATCH 4/4] riscv: switch over to generic free_initmem()

From: Souptick Joarder
Date: Mon Feb 18 2019 - 07:50:38 EST


On Mon, Feb 18, 2019 at 6:16 PM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>
> Hi Mike,
>
> On Fri, Feb 15, 2019 at 2:19 AM Palmer Dabbelt <palmer@xxxxxxxxxx> wrote:
> >
> > On Thu, 14 Feb 2019 07:59:37 PST (-0800), rppt@xxxxxxxxxxxxx wrote:
> > > The riscv version of free_initmem() differs from the generic one only in
> > > that it sets the freed memory to zero.
> > >
> > > Make ricsv use the generic version and poison the freed memory.
> > >
> > > Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
>
> Just for clarity, does same change applicable in below places -
>
> arch/openrisc/mm/init.c#L231
> arch/alpha/mm/init.c#L290
> arch/arc/mm/init.c#L213
> arch/m68k/mm/init.c#L109
> arch/nds32/mm/init.c#L247
> arch/nios2/mm/init.c#L92
> arch/openrisc/mm/init.c#L231

Please ignore this query. just saw the other patches.
Sorry for the noise.
>
>
> > > ---
> > > arch/riscv/mm/init.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> > > index 658ebf6..2af0010 100644
> > > --- a/arch/riscv/mm/init.c
> > > +++ b/arch/riscv/mm/init.c
> > > @@ -60,11 +60,6 @@ void __init mem_init(void)
> > > mem_init_print_info(NULL);
> > > }
> > >
> > > -void free_initmem(void)
> > > -{
> > > - free_initmem_default(0);
> > > -}
> > > -
> > > #ifdef CONFIG_BLK_DEV_INITRD
> > > void free_initrd_mem(unsigned long start, unsigned long end)
> > > {
> >
> > Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxx>
> >
> > I'm going to assume this goes in with the rest of the patch set, thanks!
> >