Re: [PATCH] drivers/component: kerneldoc polish

[Randy Dunlap]

On 2/18/19 12:52 AM, Daniel Vetter wrote:
> Polish the kerneldoc a bit with suggestions from Randy.
> 

Hi Daniel,
There are 2 more typos below.  With those fixed, you or Greg can add:
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Ramalingam C <ramalingam.c@xxxxxxxxx>
> --
> Greg, I don't need this in any of the topic branches, best if you
> pick this one up into your -next tree directly.
> 
> Cheers, Daniel
> ---
>  drivers/base/component.c  | 14 +++++++-------
>  include/linux/component.h |  2 +-
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/base/component.c b/drivers/base/component.c
> index 7dbc41cccd58..6954e448f46b 100644
> --- a/drivers/base/component.c
> +++ b/drivers/base/component.c
> @@ -27,7 +27,7 @@
>   * helper fills the niche of aggregate drivers for specific hardware, where
>   * further standardization into a subsystem would not be practical. The common
>   * example is when a logical device (e.g. a DRM display driver) is spread around
> - * the SoC on various component (scanout engines, blending blocks, transcoders
> + * the SoC on various components (scanout engines, blending blocks, transcoders
>   * for various outputs and so on).
>   *
>   * The component helper also doesn't solve runtime dependencies, e.g. for system
> @@ -378,7 +378,7 @@ static void __component_match_add(struct device *master,
>  }
>  
>  /**
> - * component_match_add_release - add a component match with release callback
> + * component_match_add_release - add a component match entry with release callback
>   * @master: device with the aggregate driver
>   * @matchptr: pointer to the list of component matches
>   * @release: release function for @compare_data
> @@ -408,7 +408,7 @@ void component_match_add_release(struct device *master,
>  EXPORT_SYMBOL(component_match_add_release);
>  
>  /**
> - * component_match_add_typed - add a compent match for a typed component
> + * component_match_add_typed - add a compent match entry for a typed component

                                        component

>   * @master: device with the aggregate driver
>   * @matchptr: pointer to the list of component matches
>   * @compare_typed: compare function to match against all typed components
> @@ -537,11 +537,11 @@ static void component_unbind(struct component *component,
>  }
>  
>  /**
> - * component_unbind_all - unbind all component to an aggregate driver
> + * component_unbind_all - unbind all components of an aggregate driver
>   * @master_dev: device with the aggregate driver
>   * @data: opaque pointer, passed to all components
>   *
> - * Unbinds all components to the aggregate @dev by passing @data to their
> + * Unbinds all components of the aggregate @dev by passing @data to their
>   * &component_ops.unbind functions. Should be called from
>   * &component_master_ops.unbind.
>   */
> @@ -619,11 +619,11 @@ static int component_bind(struct component *component, struct master *master,
>  }
>  
>  /**
> - * component_bind_all - bind all component to an aggregate driver
> + * component_bind_all - bind all components of an aggregate driver
>   * @master_dev: device with the aggregate driver
>   * @data: opaque pointer, passed to all components
>   *
> - * Binds all components to the aggregate @dev by passing @data to their
> + * Binds all components of the aggregate @dev by passing @data to their
>   * &component_ops.bind functions. Should be called from
>   * &component_master_ops.bind.
>   */
> diff --git a/include/linux/component.h b/include/linux/component.h
> index 30bcc7e590eb..8628d4d0aff1 100644
> --- a/include/linux/component.h
> +++ b/include/linux/component.h
> @@ -98,7 +98,7 @@ void component_match_add_typed(struct device *master,
>  	int (*compare_typed)(struct device *, int, void *), void *compare_data);
>  
>  /**
> - * component_match_add - add a compent match
> + * component_match_add - add a compent match entry

                                  component

>   * @master: device with the aggregate driver
>   * @matchptr: pointer to the list of component matches
>   * @compare: compare function to match against all components
> 


-- 
~Randy