Re: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string
From: Rob Herring
Date: Mon Feb 18 2019 - 15:07:42 EST
On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote:
> Change to use SoC compatible string instead of wildcard string.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> ---
> Changes from v1:
> - None.
> ---
> drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index ac573da..24228cf 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id sprd_pmic_eic_of_match[] = {
> - { .compatible = "sprd,sc27xx-eic", },
> + { .compatible = "sprd,sc2731-eic", },
You need to keep the old one if you care about backwards compatibility.
If you don't then state why in the commit message.
> { /* end of list */ }
> };
> MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
> --
> 1.7.9.5
>