Re: [RFC PATCH net-next v3 04/21] ethtool: helper functions for netlink interface

[Jakub Kicinski]

On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote:
> +/* create skb for a reply and fill device identification
> + * payload: payload length (without netlink and genetlink header)
> + * dev:     device the reply is about (may be null)
> + * cmd:     ETHNL_CMD_* command for reply
> + * info:    info for the received packet we respond to
> + * ehdrp:   place to store payload pointer returned by genlmsg_new()
> + * returns: skb or null on error
> + */

nit: why not correct kdoc?

> +struct sk_buff *ethnl_reply_init(size_t payload, struct net_device *dev, u8 cmd,
> +				 u16 dev_attrtype, struct genl_info *info,
> +				 void **ehdrp)
> +{
> +	void *ehdr;
> +	struct sk_buff *rskb;

nit: reverse xmas tree