Re: [PATCH v3 1/2] rtc: add AB-RTCMC-32.768kHz-EOZ9 RTC support

From: Alexandre Belloni
Date: Mon Feb 18 2019 - 16:36:12 EST


On 17/02/2019 21:52:56+0300, Artem Panfilov wrote:
> This patch adds support for AB-RTCMC-32.768kHz-EOZ9 RTC/Calendar
> module with I2C interface.
>
> v3:
> - Move validity check before reading time registers
> - Add V1F/V2F check before reading the temperature
> - Fix missing check of a return value
>
> v2:
> - Remove a package denomination in variable names and files
> - Fix read/write time registers length
> - Replace regmap_update_bits with regmap_write during probing
> - Add a check and reset for PON, V2F, V1F registers
> - Rename registers according to the datasheet
>
> Signed-off-by: Artem Panfilov <panfilov.artyom@xxxxxxxxx>
> ---
> drivers/rtc/Kconfig | 10 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-ab-eoz9.c | 465 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 476 insertions(+)
> create mode 100644 drivers/rtc/rtc-ab-eoz9.c
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com