Re: [PATCH 02/14] ARM: dts: IGEP: Add WiLink UART node

From: Enric Balletbo Serra
Date: Mon Feb 18 2019 - 17:05:02 EST


Hi Sebastian,

Sorry to take so long to reply

Missatge de Sebastian Reichel <sre@xxxxxxxxxx> del dia dv., 21 de des.
2018 a les 9:05:
>
> From: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
>
> Add a node for the UART part of WiLink chip.
>
> Cc: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> This is compile tested only!
> ---
> arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 8 ++++++++
> arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 8 ++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
> index 285681d7af49..8bb4298ca05e 100644
> --- a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
> +++ b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts
> @@ -52,3 +52,11 @@
> interrupts = <17 IRQ_TYPE_EDGE_RISING>; /* gpio 177 */
> };
> };
> +
> +&uart2 {
> + bluetooth {
> + compatible = "ti,wl1835-st";

That should be "ti,wl1831-st"

> + enable-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>; /* gpio 137 */
> + max-speed = <300000>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> index 1adc73bd2ca0..03be171e9de7 100644
> --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> @@ -74,3 +74,11 @@
> interrupts = <8 IRQ_TYPE_EDGE_RISING>; /* gpio 136 */
> };
> };
> +
> +&uart2 {
> + bluetooth {
> + compatible = "ti,wl1835-st";

That should be "ti,wl1831-st"

> + enable-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>; /* gpio 137 */
> + max-speed = <300000>;
> + };
> +};
> --
> 2.19.2
>

Apart from that,

Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>