Re: linux-next: Fixes tag needs some work in Linus' tree

From: Changbin Du
Date: Mon Feb 18 2019 - 20:58:49 EST


On Tue, Feb 19, 2019 at 07:33:45AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> [Just a note for some future improvement]
>
> In commit
>
> 2c4f1fcbef0b ("kprobe: Do not use uaccess functions to access kernel memory that can fault")
>
> Fixes tag
>
> Fixes: 9da3f2b7405 ("x86/fault: BUG() when uaccess helpers fault on kernel addresses")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> --
Thanks for reminding. The scripts/checkpatch.pl does has such check but
it only checks the commit message body. I will try to extend it to
include tags, and hint how to configure git.

> Cheers,
> Stephen Rothwell



--
Cheers,
Changbin Du