Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

From: Jason Wang
Date: Tue Feb 19 2019 - 01:51:37 EST



On 2019/2/16 äå12:45, Stephen Hemminger wrote:
On Fri, 15 Feb 2019 15:53:24 +0800
Jason Wang <jasowang@xxxxxxxxxx> wrote:

When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.

Reported-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
Fixes: cc5e71075947 ("vhost: log dirty page correctly")
Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
Looks good. It is best to put the Addresses-Coverity-Id tag on these kind
of bug fixes so that the automated tools see it.


Ok. Will do this in V2.

Thanks