Re: [PATCH v2 04/15] ARM: milbeaut: Add basic support for Milbeaut m10v SoC

[Sugaya, Taichi]

Hi,

Thank you for your comments.

On 2019/02/18 21:15, Arnd Bergmann wrote:
> On Fri, Feb 8, 2019 at 1:26 PM Sugaya Taichi
> <sugaya.taichi@xxxxxxxxxxxxx> wrote:
>
> > +static int m10v_pm_enter(suspend_state_t state)
> > +{
> > +       switch (state) {
> > +       case PM_SUSPEND_STANDBY:
> > +               pr_err("STANDBY\n");
> > +               asm("wfi");
> > +               break;
> > +       case PM_SUSPEND_MEM:
> > +               pr_err("SUSPEND\n");
> > +               cpu_pm_enter();
> > +               cpu_suspend(0, m10v_die);
> > +               cpu_pm_exit();
> > +               break;
> > +       }
> > +       return 0;
> > +}
>
> It looks like you left the pr_err() messages from bringup, they should probably
> be removed now.

OK. remove the pr_err()s.


> > +static int __init m10v_pm_init(void)
> > +{
> > +       suspend_set_ops(&m10v_pm_ops);
> > +
> > +       return 0;
> > +}
> > +late_initcall(m10v_pm_init);
>
> This requires a check to ensure you are actually on the right platform,
> otherwise you break suspend/resume in a multiplatform kernel running
> on anything other than milbeaut.

OK.
I think the solution is adding a "if statement with mlbeaut compatible" 
above suspend_set_ops(&m10v_pm_ops).

Thanks,
Sugaya Taichi


>         Arnd