[PATCH][next] usb: typec: mux: remove redundant check on variable match

From: Colin King
Date: Tue Feb 19 2019 - 08:43:38 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

All the code paths that lead to the return statement are where
match is always true, hence the check to see if it is true is
redundant and can be removed.

Detected by CoverityScan, CID#14769672 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/usb/typec/mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c
index a5947d98824d..b94e2920eb38 100644
--- a/drivers/usb/typec/mux.c
+++ b/drivers/usb/typec/mux.c
@@ -184,7 +184,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data)
if (dev_fwnode(mux->dev) == con->fwnode)
return mux;

- return match ? ERR_PTR(-EPROBE_DEFER) : NULL;
+ return ERR_PTR(-EPROBE_DEFER);
}

/**
--
2.20.1