[PATCH] udf: Drop pointless check from udf_sync_fs()

From: Jan Kara
Date: Tue Feb 19 2019 - 08:59:43 EST


The check if (bh) in udf_sync_fs() is pointless as we cannot have
sbi->s_lvid_dirty and !sbi->s_lvid_bh (as already asserted by
udf_updated_lvid()). So just drop the pointless check.

Reported-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
fs/udf/super.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/udf/super.c b/fs/udf/super.c
index a6940d90bedd..ffd8038ff728 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -2330,13 +2330,10 @@ static int udf_sync_fs(struct super_block *sb, int wait)
mutex_lock(&sbi->s_alloc_mutex);
if (sbi->s_lvid_dirty) {
struct buffer_head *bh = sbi->s_lvid_bh;
+ struct logicalVolIntegrityDesc *lvid;

- if (bh) {
- struct logicalVolIntegrityDesc *lvid;
-
- lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
- udf_finalize_lvid(lvid);
- }
+ lvid = (struct logicalVolIntegrityDesc *)bh->b_data;
+ udf_finalize_lvid(lvid);

/*
* Blockdevice will be synced later so we don't have to submit
--
2.16.4


--cWoXeonUoKmBZSoM--