Re: [PATCH V4 2/2] i2c: tegra: remove multi-master support

From: Thierry Reding
Date: Tue Feb 19 2019 - 12:13:02 EST


On Mon, Feb 18, 2019 at 08:50:25PM -0800, Sowjanya Komatineni wrote:
> multi-master support is defeatured on Tegra210 and Tegra186 due to
> known bugs.

Nit: "Multi-master" because it's the beginning of a sentence.

>
> This patch removes multi-master support for Tegra210 and Tegra186
> i2c hw feature.

Nit: i2c -> I2C, hw -> HW

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

>
> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index e6851904acc1..26f686bc3491 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -1409,7 +1409,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
> .clk_divisor_fast_mode = 0x19,
> .clk_divisor_fast_plus_mode = 0x10,
> .has_config_load_reg = true,
> - .has_multi_master_mode = true,
> + .has_multi_master_mode = false,
> .has_slcg_override_reg = true,
> .has_mst_fifo = false,
> .quirks = &tegra_i2c_quirks,
> @@ -1434,7 +1434,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
> .clk_divisor_fast_mode = 0x19,
> .clk_divisor_fast_plus_mode = 0x10,
> .has_config_load_reg = true,
> - .has_multi_master_mode = true,
> + .has_multi_master_mode = false,
> .has_slcg_override_reg = true,
> .has_mst_fifo = false,
> .quirks = &tegra_i2c_quirks,
> --
> 2.7.4
>

Attachment: signature.asc
Description: PGP signature