Re: [PATCH][next] ptp_qoriq: don't pass a large struct by value but instead pass it by reference

From: David Miller
Date: Tue Feb 19 2019 - 17:16:00 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 19 Feb 2019 14:21:20 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes
> of data by value on the stack. Optimize this by passing it by reference instead.
> Also shinks the object code size:
>
> Before:
> text data bss dec hex filename
> 12596 2160 64 14820 39e4 drivers/ptp/ptp_qoriq.o
>
> After:
> text data bss dec hex filename
> 12567 2160 64 14791 39c7 drivers/ptp/ptp_qoriq.o
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Looks good, applied, thanks.