Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

[Chen Yu]

Hi,

On 2019/2/19 16:25, Sergei Shtylyov wrote:
> Hello!
> 
> On 18.02.2019 14:23, Yu Chen wrote:
> 
>> This patch adds binding documentation to support usb hub and usb
>> data role switch of Hisilicon HiKey960 Board.
>>
>> Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>> Cc: John Stultz <john.stultz@xxxxxxxxxx>
>> Cc: Binghui Wang <wangbinghui@xxxxxxxxxxxxx>
>> Signed-off-by: Yu Chen <chenyu56@xxxxxxxxxx>
>> ---
>> v1:
>> * Fix some format errors as suggested by Sergei.
>> * Modify gpio description to use gpiod API.
>> v2:
>> * Remove information about Hikey.
>> * Fix gpio description.
>> * Remove device_type of endpoint.
>> ---
>> ---
>> Â .../bindings/misc/hisilicon-hikey-usb.txtÂÂÂÂÂÂÂÂÂ | 35 ++++++++++++++++++++++
>> Â 1 file changed, 35 insertions(+)
>> Â create mode 100644 Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
>>
>> diff --git a/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt b/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
>> new file mode 100644
>> index 000000000000..c2b789b515df
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt
>> @@ -0,0 +1,35 @@
>> +Support usb hub and usb data role switch of Hisilicon HiKey960 Board.
>> +
>> +-----------------------------
>> +
>> +Required properties:
>> +- compatible: "hisilicon,gpio-hubv1","hisilicon,hikey960-usb"
> 
> ÂÂ Only one of those, looking at your example?
"hisilicon,gpio-hubv1" is similar as "hisilicon,hikey960-usb".

> ÂÂ Need a space after comma, BTW.
OK. Thanks!

> 
>> +- typec-vbus-gpios: gpio to control the vbus of typeC port
>> +- typec-vbus-enable-val: gpio value that enable the vbus of typeC port
> 
> ÂÂ Hm, I thought that can be inferred from the GPIO specifier above...
> 
OK. Thanks!

>> +- otg-switch-gpios: gpio to switch DP & DM between the hub and typeC port
>> +- hub-vdd33-en-gpios: gpio to enable the power of hub
>> +- pinctrl-0: pinctrl config
> 
> ÂÂ You forgot about "pinctrl-names"...
OK. Thanks!

> 
>> +
>> +Example
>> +-----
>> +
>> +ÂÂÂ hisi_hikey_usb: hisi_hikey_usb {
>> +ÂÂÂÂÂÂÂ compatible = "hisilicon,hikey960-usb";
>> +ÂÂÂÂÂÂÂ typec-vbus-gpios = <&gpio25 2 0>;
>> +ÂÂÂÂÂÂÂ typec-vbus-enable-val = <1>;
>> +ÂÂÂÂÂÂÂ otg-switch-gpios = <&gpio25 6 0>;
>> +ÂÂÂÂÂÂÂ hub-vdd33-en-gpios = <&gpio5 6 0>;
>> +ÂÂÂÂÂÂÂ pinctrl-names = "default";
>> +ÂÂÂÂÂÂÂ pinctrl-0 = <&usbhub5734_pmx_func>;
>> +
>> +ÂÂÂÂÂÂÂ port {
>> +ÂÂÂÂÂÂÂÂÂÂÂ #address-cells = <1>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ #size-cells = <0>;
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂ hikey_usb_ep: endpoint@0 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ reg = <0>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ remote-endpoint = <&dwc3_role_switch_notify>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂ };
> 
> MBR, Sergei
> 
> .
> 

Thanks
Yu Chen