Re: linux-next: Fixes tag needs some work in the kvm tree
From: Yu Zhang
Date: Wed Feb 20 2019 - 02:07:30 EST
Thanks for the notification, Stephen.
@Paolo, should I resubmit the patch to correct?
On Sat, Feb 16, 2019 at 06:34:33PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> aa8359972cfc ("KVM: x86/mmu: Differentiate between nr zapped and list unstable")
>
> Fixes tag
>
> Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return
>
> has these problem(s):
>
> - Subject has leading but no trailing quotes
> Please do not split Fixes tags over more than one line
>
> In commit
>
> 4d3f8e4ff75e ("kvm: vmx: Fix typos in vmentry/vmexit control setting")
>
> Fixes tag
>
> Fixes: 'commit f99e3daf94ff ("KVM: x86: Add Intel PT virtualization work mode")'
>
> has these problem(s):
>
> - No SHA1 recognised
> The leading word 'commit' is unexpected and the surrounding single
> quotes likewise.
> Please just use
> git log -1 --format='Fixes: %h ("%s")' <SHA>
>
> --
> Cheers,
> Stephen Rothwell
B.R.
Yu