Re: [PATCH v3 1/2] gpio: AMD G-Series PCH gpio driver

From: Linus Walleij
Date: Wed Feb 20 2019 - 04:46:01 EST


On Thu, Feb 14, 2019 at 11:05 PM Enrico Weigelt, metux IT consult
<info@xxxxxxxxx> wrote:

> GPIO platform driver for the AMD G-series PCH (eg. on GX-412TC)
>
> This driver doesn't registers itself automatically, as it needs to
> be provided with platform specific configuration, provided by some
> board driver setup code.
>
> Didn't implement oftree probing yet, as it's rarely found on x86.
>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linus.walleij@xxxxxxxxxx
> Cc: bgolaszewski@xxxxxxxxxxxx
> Cc: dvhart@xxxxxxxxxxxxx
> Cc: andy@xxxxxxxxxxxxx
> Cc: platform-driver-x86@xxxxxxxxxxxxxxx
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@xxxxxxxxx>

(...)
> +config GPIO_AMD_FCH
> + tristate "GPIO support for AMD Fusion Controller Hub (G-series SOCs)"
> + select GPIO_GENERIC

Now I see that you do this

> + spin_lock_irqsave(&priv->gc.bgpio_lock, flags);
(...)
> + spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags);

Only to get that spinlock.

That's not what GPIO_GENERIC is for, just put a spinlock in your
local state container struct amd_fch_gpio_priv instead.

Yours,
Linus Walleij