Re: [PATCH v3 9/9] ARM: configs: Add Milbeaut M10V defconfig

[Sugaya, Taichi]

Hi

On 2019/02/20 18:28, Arnd Bergmann wrote:
> On Wed, Feb 20, 2019 at 8:44 AM Sugaya Taichi
> <sugaya.taichi@xxxxxxxxxxxxx> wrote:
>
> > diff --git a/arch/arm/configs/milbeaut_m10v_defconfig b/arch/arm/configs/milbeaut_m10v_defconfig
> > new file mode 100644
> > index 0000000..a263211
> > --- /dev/null
> > +++ b/arch/arm/configs/milbeaut_m10v_defconfig
> > @@ -0,0 +1,175 @@
>
> I no longer see anything here that should be turned off, but you
> might want to run 'make savedefconfig' and use the output of that,
> to make it easier to keep it up to date.

I got it, I use the output of 'make savedefconfig'.
One question, is that OK to add some options on it?
 -Because "CONFIG_ARCH_MILBEAUT" was not listed.


> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> > index 5bee34a..6753805 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -54,6 +54,8 @@ CONFIG_SOC_VF610=y
> >   CONFIG_ARCH_KEYSTONE=y
> >   CONFIG_ARCH_MEDIATEK=y
> >   CONFIG_ARCH_MESON=y
> > +CONFIG_ARCH_MILBEAUT=y
> > +CONFIG_ARCH_MILBEAUT_M10V=y
> >   CONFIG_ARCH_MVEBU=y
> >   CONFIG_MACH_ARMADA_370=y
> >   CONFIG_MACH_ARMADA_375=y
>
> I'm surprised that you don't need to enable any drivers. Does this actually
> boot on your hardware?

Yes, but not exactly.
The series has not serial driver, so I add the driver temporarily and 
confirm the boot log through earlycon.
The timer driver is selected by "CONFIG_ARCH_MILBEAUT_M10V", no need to 
add the the"CONFIG_MILBEAUT_TIMER".

Here one more question.
Is this OK to submit a core support patch without any serial drivers?

Thanks,
Sugaya Taichi

>        Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel