Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters

[Nikolaus Voss]

On Wed, 20 Feb 2019, Heikki Krogerus wrote:
> On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote:
> > On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote:
> > > On Wed, 20 Feb 2019, Heikki Krogerus wrote:
> > > > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote:
> > > > > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C
> > > > > adapters, but the problem described with regmap-i2c not handling
> > > > > SMBus block transfers (i.e. read and writes) correctly also exists
> > > > > with writes.
> > > > >
> > > > > As workaround, this patch adds a block write function the same way
> > > > > 1a2f474d328f adds a block read function.
> > > > >
> > > > > Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters")
> > > > > Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
> > > > > Signed-off-by: Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>
> > > >
> > > > You are missing a "from" line with address that matches your SoB
> > > > address.
> > >
> > > That's because I currently cannot send patch mails from my company account
> > > as our MTA breaks diffs.
> >
> > I understand, but you can have a separate "From line" in your patch,
> > i.e. you send the patch using one address, and have an extra "From
> > line" (outside of the mail header) with another address.
> >
> > That other From line will be interpreted as the author address, and
> > it should match your SoB address.
> >
> >
> > Try something like this in a branch where this patch is the HEAD:
> >
> >         % export MY_COMMIT=$(git show -s --pretty=%h HEAD)
> >         % git reset HEAD^
> >         % GIT_COMMITTER_IDENT='Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>' \
> >           GIT_AUTHOR_IDENT='Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>' \
> >           git commit -a -C $MY_COMMIT
>
> Correction here:
>
>        % GIT_COMMITTER_IDENT='Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>' \
>          GIT_AUTHOR_IDENT='Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>' \
>          git commit -a -C $MY_COMMIT --reset-author
>
> That "--reset-author" was missing. Sorry for that.

Thanks, Heikki, I'll give it a try...

Nikolaus