Re: [PATCH 5/9] iio: accel: bma180: convert to devm

From: Andy Shevchenko
Date: Wed Feb 20 2019 - 11:10:00 EST


On Wed, Feb 20, 2019 at 03:00:52PM +0100, H. Nikolaus Schaller wrote:
> This simplifies the code a little.

> -err_buffer_cleanup:
> - iio_triggered_buffer_cleanup(indio_dev);
> -err_trigger_unregister:
> - if (data->trig)
> - iio_trigger_unregister(data->trig);
> -err_trigger_free:
> - iio_trigger_free(data->trig);

> -err_chip_disable:
> +err:

Please, leave the original label name as it's more self-explanatory.

> data->part_info->chip_disable(data);
>
> return ret;

--
With Best Regards,
Andy Shevchenko