Re: [PATCH v2] platform/x86: wmi: fix potential null pointer dereference

From: Darren Hart
Date: Wed Feb 20 2019 - 20:29:52 EST


On Wed, Jan 30, 2019 at 05:43:34PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 30, 2019 at 5:15 PM Mattias Jacobsson <2pi@xxxxxx> wrote:
> >
> > In the function wmi_dev_match() the variable id is dereferenced without
> > first performing a NULL check. The variable can for example be NULL if
> > a WMI driver is registered without specifying the id_table field in
> > struct wmi_driver.
> >
> > Add a NULL check and return that the driver can't handle the device if
> > the variable is NULL.
> >
>
> Good for me, thanks!

Queued for testing, thanks Mattias.

--
Darren Hart
VMware Open Source Technology Center