Re: [PATCH v3 2/3] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU

From: Georgi Djakov
Date: Thu Feb 21 2019 - 07:06:18 EST


Hi,

On 12/20/18 19:30, Jordan Crouse wrote:
> Add documentation for the interconnect and interconnect-names bindings
> for the GPU node as detailed by bindings/interconnect/interconnect.txt.
>
> Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx>
> ---
>
> Documentation/devicetree/bindings/display/msm/gpu.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt
> index 9c89f4fdb8ca..5b04393dcb15 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.txt
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt
> @@ -20,6 +20,8 @@ Required properties:
> - qcom,adreno-630.2
> - iommus: optional phandle to an adreno iommu instance
> - operating-points-v2: optional phandle to the OPP operating points
> +- interconnect: optional phandle to a interconnect provider. See

Nit: s/interconnect:/interconnects:/
Nit: s/a interconnect/an interconnect/

> + ../interconnect/interconnect.txt for details.
> - qcom,gmu: For GMU attached devices a phandle to the GMU device that will
> control the power for the GPU. Applicable targets:
> - qcom,adreno-630.2
> @@ -68,6 +70,8 @@ Example a6xx (with GMU):
>
> operating-points-v2 = <&gpu_opp_table>;
>
> + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>;
> +
> qcom,gmu = <&gmu>;
> };
> };
>

Acked-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>

Thanks,
Georgi