Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()

[Jarkko Sakkinen]

On Wed, Feb 20, 2019 at 09:00:42AM -0700, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 08:31:59AM +0200, Jarkko Sakkinen wrote:
> > On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> > > calc_tpm2_event_size() has an invalid signature because
> > > it returns a 'size_t' where as its signature says that
> > > it returns 'int'.
> > > 
> > > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
> > > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> > 
> > Two remarks:
> > 
> > - git config user.name "Yue Haibing"
> > - "Cc: stable@xxxxxxxxxxxxxxx" before the fixes tag.
> 
> 'Theoretical' bug fixes are not suitable for stable

AFAIK there is no hard rule here. For this one line change I think it
makes sense to backport it even if it is only for avoiding conflicts
with future backports.

/Jarkko