Re: [PATCH v11] dm: add support to directly boot to a mapped device

From: Kees Cook
Date: Thu Feb 21 2019 - 12:13:53 EST


On Thu, Feb 21, 2019 at 7:50 AM Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
>
> On Mon, Feb 18 2019 at 1:18pm -0500,
> Helen Koike <helen.koike@xxxxxxxxxxxxx> wrote:
>
> > Add a dm-mod.create= kernel module parameter.
> > It allows device-mapper targets to be configured at boot time for use early
> > in the boot process (as the root device or otherwise).
> >
> > Signed-off-by: Will Drewry <wad@xxxxxxxxxxxx>
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > [rework to use dm_ioctl calls]
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> > [refactored for upstream]
> > Signed-off-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>
>
> Can I get confirmation from Will and Kees that this v11 is safe to carry
> their Signed-off-by? Are you guys "happy" with this patch?

I think those should be "Co-developed-by:" to more correctly capture
the intent. At this point I think Helen is the primary author. Or at
least, Will and I aren't anymore. :)

At first pass, yes, this patch does what's needed for Chrome OS and
Android, but I'll take a closer look shortly (and I've added David who
has looked at this most recently).

Thanks!

--
Kees Cook