Re: [PATCH] irqchip: brcmstb-l2: use _irqsave variants in non-interrupt code

[Florian Fainelli]

On 2/21/19 2:15 AM, Marc Zyngier wrote:
> On Wed, 20 Feb 2019 14:15:28 -0800
> Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> 
>> From: Doug Berger <opendmb@xxxxxxxxx>
>>
>> Using the irq_gc_lock/irq_gc_unlock functions in the suspend and
>> resume functions creates the opportunity for a deadlock during
>> suspend, resume, and shutdown. Using the irq_gc_lock_irqsave/
>> irq_gc_unlock_irqrestore variants prevents this possible deadlock.
>>
>> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> 
> Applied to irqchip-next with:
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 7f646e92766e2 ("irqchip: brcmstb-l2: Add Broadcom Set Top Box
> Level-2 interrupt controller")
> 
> Now, I'm worried this is not the only issue, see below.

Thanks for adding the Fixes tag, I should have done that, but did not
consider it to be a particularly serious issue (we have not see it in
real life, just only when LOCKDEP is enabled).
-- 
Florian