Re: [PATCH] IB/hfi1: Add missing break in switch statement

[Gustavo A. R. Silva]

On 2/21/19 3:09 PM, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote:
>> Fix the following warning by adding a missing break:
>>
>> drivers/infiniband/hw/hfi1/tid_rdma.c: In function âhfi1_tid_rdma_wqe_interlockâ:
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    switch (prev->wr.opcode) {
>>    ^~~~~~
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
>>   case IB_WR_RDMA_READ:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> Reviewed-by: Kaike Wan <Kaike.wan@xxxxxxxxx>
>> --
>>  drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Applied to for-next, thanks
> 

Great. :)

Thank you both, Kaike and Jason.

--
Gustavo