Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

[Gao Xiang]

On 2019/2/22 8:57, YU Bo wrote:
> Hi,
> On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>> Hi Bo,
>>
>> On 2019/2/21 22:28, Bo YU wrote:
>>> From: Bo Yu <tsu.yubo@xxxxxxxxx>
>>>
>>> Fix sparse warnings:
>>>
>>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>>
>>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>>> Cc: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>>> Cc: Chao Yu <yuchao0@xxxxxxxxxx>
>>> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Bo Yu <tsu.yubo@xxxxxxxxx>
>>> ---
>>> Âdrivers/staging/erofs/utils.c | 2 +-
>>> Â1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>>> index b535898ca753..33cd5ad55cb8 100644
>>> --- a/drivers/staging/erofs/utils.c
>>> +++ b/drivers/staging/erofs/utils.c
>>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>>> ÂÂÂÂ __erofs_workgroup_free(grp);
>>> Â}
>>>
>>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ struct erofs_workgroup *grp,
>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ bool cleanup)
>>> Â{
>>>
>>
>> Have you looked the latest kernel code?
> Emm...yeah.But i pulled linus tree not staging tree :(
> Sorry for the noise.

That is ok. staging tree or linux-next includes the latest source code,
you can check them out :)

Thanks,
Gao Xiang

> 
>> It seems erofs_try_to_release_workgroup is already be claimed as static...
>>
>> See:
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>>
>> Thanks,
>> Gao Xiang
>>