Re: [RESEND PATCH 1/1] headers_install.sh: Support __aligned(x) for uAPI headers

[Masahiro Yamada]

On Thu, Feb 21, 2019 at 10:29 PM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> The headers-install.sh already supports __packed conversion to
> __attribute__((packed)) for uAPI headers but it does not support similar
> __aligned(x) conversion.
>
> Add support for __aligned(x).


I am not a big fan of sed scripting in headers_install.sh

Is it a problem to write __attribute__((aligned(x)) in UAPI headers?



> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
>  scripts/headers_install.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> index 593f8879c641..9ed490f33a3a 100755
> --- a/scripts/headers_install.sh
> +++ b/scripts/headers_install.sh
> @@ -36,6 +36,7 @@ do
>                 -e 's/__attribute_const__([[:space:]]|$)/\1/g' \
>                 -e 's@^#include <linux/compiler(|_types).h>@@' \
>                 -e 's/(^|[^a-zA-Z0-9])__packed([^a-zA-Z0-9_]|$)/\1__attribute__((packed))\2/g' \
> +               -e 's/(^|[^a-zA-Z0-9])__aligned(\([0-9 ]*\))([^a-zA-Z0-9_]|$)/\1__attribute__((aligned\2))\3/g' \
>                 -e 's/(^|[[:space:](])(inline|asm|volatile)([[:space:](]|$)/\1__\2__\3/g' \
>                 -e 's@#(ifndef|define|endif[[:space:]]*/[*])[[:space:]]*_UAPI@#\1 @' \
>                 "$SRCDIR/$i" > "$OUTDIR/$FILE.sed" || exit 1
> --
> 2.11.0
>


-- 
Best Regards
Masahiro Yamada