Re: [PATCH] bpfilter: re-add header search paths to tools include to fix build error

[Guenter Roeck]

On 2/21/19 7:23 PM, Masahiro Yamada wrote:
> I thought header search paths to tools/include(/uapi) were unneeded,
> but it looks like a build error occurs depending on the compiler.
>
> Commit 303a339f30a9 ("bpfilter: remove extra header search paths for
> bpfilter_umh") reintroduced the build error fixed by commit ae40832e53c3
> ("bpfilter: fix a build err").
>
> Apology for the breakage, and thanks to Guenter for reporting this.
>
> Fixes: 303a339f30a9 ("bpfilter: remove extra header search paths for bpfilter_umh")
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>
> Guenter,
>
> Sorry for bothering you, but
> could you please test this with your compiler?
>
> I am also using GCC 7.3, but my compiler cannot
> reproduce the build error.
>
>
>   net/bpfilter/Makefile | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
> index 5d6c776..854395f 100644
> --- a/net/bpfilter/Makefile
> +++ b/net/bpfilter/Makefile
> @@ -5,6 +5,7 @@
>   
>   hostprogs-y := bpfilter_umh
>   bpfilter_umh-objs := main.o
> +KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi
>   HOSTCC := $(CC)
>   
>   ifeq ($(CONFIG_BPFILTER_UMH), y)