Re: [PATCH v1 3/4] KVM: arm/arm64: Define TCR_EL2_T0SZ_MASK as TCR_T0SZ_MASK

From: Mark Rutland
Date: Fri Feb 22 2019 - 06:43:56 EST


On Fri, Feb 22, 2019 at 04:23:25PM +0800, Leo Yan wrote:
> Define macro TCR_EL2_T0SZ_MASK as TCR_T0SZ_MASK, so can remove the hard
> number 0x3f.
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>

Given we do this for the other TCR fields, and the value is correct
AFAICT, this makes sense to me. FWIW:

Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.

> ---
> arch/arm64/include/asm/kvm_arm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h
> index 6f602af5263c..d945a787f36e 100644
> --- a/arch/arm64/include/asm/kvm_arm.h
> +++ b/arch/arm64/include/asm/kvm_arm.h
> @@ -99,7 +99,7 @@
> #define TCR_EL2_SH0_MASK TCR_SH0_MASK
> #define TCR_EL2_ORGN0_MASK TCR_ORGN0_MASK
> #define TCR_EL2_IRGN0_MASK TCR_IRGN0_MASK
> -#define TCR_EL2_T0SZ_MASK 0x3f
> +#define TCR_EL2_T0SZ_MASK TCR_T0SZ_MASK
> #define TCR_EL2_MASK (TCR_EL2_TG0_MASK | TCR_EL2_SH0_MASK | \
> TCR_EL2_ORGN0_MASK | TCR_EL2_IRGN0_MASK | TCR_EL2_T0SZ_MASK)
>
> --
> 2.17.1
>