Re: [PATCH v2 08/10] MIPS: SGI-IP27: use generic PCI driver
From: Christoph Hellwig
Date: Fri Feb 22 2019 - 09:46:36 EST
> diff --git a/arch/mips/include/asm/dma-direct.h b/arch/mips/include/asm/dma-direct.h
> index b5c240806e1b..bd11e7934df1 100644
> --- a/arch/mips/include/asm/dma-direct.h
> +++ b/arch/mips/include/asm/dma-direct.h
> @@ -2,6 +2,8 @@
> #ifndef _MIPS_DMA_DIRECT_H
> #define _MIPS_DMA_DIRECT_H 1
> +#include <dma-direct.h>
> static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
> if (!dev->dma_mask)
How is your mach dma-direct.h scheme going to work, given that
we already have non-inline declarations of __phys_to_dma / __dma_to_phys
in this file?
Also this really should go into a separate commit, and we should either
have all of these functions inline or none. Having all of them out
of line seemed a lot saner to me to avoid all the mach header mess.
Also there seem to be a lot of randomw whitespace / brace cleanups
in this patch. Shouldn't those be split out as well?