Re: [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf

From: shuah
Date: Fri Feb 22 2019 - 10:59:13 EST


Hi Juerg,

On 2/22/19 7:58 AM, Masami Hiramatsu wrote:
On Fri, 22 Feb 2019 10:10:20 +0100
Juerg Haefliger <juerg.haefliger@xxxxxxxxxxxxx> wrote:

echo -e is not POSIX. Depending on what /bin/sh is, we can get
incorrect output like:
$ -e -n [1] Basic trace file check
$ -e [PASS]

Fix that by using printf instead.

Signed-off-by: Juerg Haefliger <juergh@xxxxxxxxxxxxx>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>


I wasn't on the To or Cc on the original patch. Make sure to
run the get_maintainers and include the people it recommends.

Please resend the patch to me, so I can take it for 5.1-rc1

thanks,
-- Shuah