Re: [PATCH v7 00/23] locking/lockdep: Add support for dynamic keys

[Bart Van Assche]

On 2/22/19 8:26 AM, Peter Zijlstra wrote:
> I've gone over all and I think it looks ok now; I'll give it another
> round tomorrow^Wmonday and then queue bits.
>
> So far the only changes I've made are the below. I'm not entirely sure
> on the unconditional validity check on DEBUG_LOCKDEP, maybe I'll add a
> boot param for that.

Hi Peter,

Please keep in mind that calling check_data_structures() slows down the 
kernel a lot and also that it makes systems much less responsive. This 
is because the consistency checks disable interrupts for a long time, up 
to several seconds. That is why I think it should be possible to enable 
and disable the consistency checks independent of other kernel config 
options.

Thanks,

Bart.