Re: [PATCH V4 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number
From: Rob Herring
Date: Fri Feb 22 2019 - 12:37:44 EST
On Wed, 20 Feb 2019 11:40:40 +0000, Aisheng Dong wrote:
> Not all 64 interrupts may be used in one group. e.g. most irqsteer in
> imx8qxp and imx8qm subsystems supports only 32 interrupts.
>
> As the IP integration parameters are Channel number and interrupts number,
> let's use fsl,irqs-num to represents how many interrupts supported
> by this irqsteer channel.
>
> Note this will break the compatibility of old binding. As the original
> fsl,irq-groups was born out of a misunderstanding of the HW config
> options and we are not aware of any users of the current binding.
> And the old binding was just published in recent months, so it's
> worth to change now to avoid confusing in the future.
>
> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> ---
> ChangeLog:
> v3->v4:
> * add more commit messages to describe the compatibility break
> v2->v3:
> * no changes
> v1->v2:
> * change property name fsl,irqs-per-chan to fsl,num-irqs.
> ---
> .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>