Re: [PATCH 3/3] net: ethernet: add support for high speed mac and usxgmii pcs

From: Andrew Lunn
Date: Fri Feb 22 2019 - 16:44:12 EST


> if (macb_is_gem(bp)) {
> - linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
> - if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
> - linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
> - phydev->supported);
> + if (bp->caps & MACB_CAPS_HIGH_SPEED) {
> + linkmode_copy(phydev->supported, PHY_10GBIT_FEATURES);
> + } else {
> + u32 bitmask = ETHTOOL_LINK_MODE_2500baseT_Full_BIT;
> +
> + linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
> + if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
> + linkmode_set_bit(bitmask, phydev->supported);
> + }

Same issue again. Somebody could be using a 10G MAC with a 2.5G PHY.

Andrew