Re: [PATCH 2/2] habanalabs: driver's Kconfig must select DMA_SHARED_BUFFER

[Oded Gabbay]

On Sat, Feb 23, 2019 at 11:34 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Feb 23, 2019 at 11:19:07AM +0200, Oded Gabbay wrote:
> > On Sat, Feb 23, 2019 at 11:17 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Fri, Feb 22, 2019 at 09:29:59PM +0200, Oded Gabbay wrote:
> > > > The driver uses the DMA_BUF module which is built only if
> > > > DMA_SHARED_BUFFER is selected. DMA_SHARED_BUFFER doesn't have any
> > > > dependencies so it is ok to select it (as done by many other components).
> > > >
> > > > Signed-off-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>
> > >
> > > kbuild reported this, right?  You should always add that type of credit
> > > to the patch.  I'll go add it by hand this time...
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Ah, I didn't know that, sorry. It wasn't enforced in drm :(
>
> Really?  The drm developers should know better, that's not ok :(
Well, perhaps it wasn't enforced only for the few instances that I
fixed those errors and usually it is enforced.
I don't want to smear the entire drm developers community based on a
small set of examples.
Thanks,
Oded