Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device()

[Dmitry Osipenko]

Ð Mon, 25 Feb 2019 02:27:19 +0000
Peter Chen <peter.chen@xxxxxxx> ÐÐÑÐÑ:

>  
> > 
> > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for
> > Tegra20/30/114/124")  
> 
> I suppose you need to apply at stable tree too, right?
> 

It is enough to have the "Fixes" tag to get patch backported into all
relevant kernel versions.

> > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> > ---
> >  drivers/usb/chipidea/ci_hdrc_tegra.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > index 772851bee99b..12025358bb3c 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct
> > platform_device *pdev) {
> >  	struct tegra_udc *udc = platform_get_drvdata(pdev);
> > 
> > +	ci_hdrc_remove_device(udc->dev);
> >  	usb_phy_set_suspend(udc->phy, 1);
> >  	clk_disable_unprepare(udc->clk);
> >   
>  
> Acked-by: Peter Chen <peter.chen@xxxxxxx>
> 
> Hi Greg, would you still accept the bug-fix for this release (v5.0)?
> Or I send you later?

I just want to point out that the bug existed for a very long time and
apparently didn't bother anybody, hence it's not an urgent fix.