Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

[Enric Balletbo i Serra]

Hi Randy,

Thanks for the report

On 22/2/19 17:50, Randy Dunlap wrote:
> On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote:
>> Hi,
>>
>> On 21/2/19 0:09, Randy Dunlap wrote:
>>> On 2/20/19 2:11 PM, Nick Crews wrote:
>>>> In the initial version of the Wilco EC Driver, the
>>>> dependency order was wrong. It before was possible to
>>>> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without
>>>> having CONFIG_CROS_EC_LPC_MEC. This was wrong, since
>>>> WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the
>>>> other way around.
>>>>
>>>> Fixes: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
>>>> Signed-off-by: Nick Crews <ncrews@xxxxxxxxxxxx>
>>>
>>> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
>>>
>>
>> As this is [-next] material I squashed that commit and queued for 5.1
> 
> Hi,
> 
> on linux-next of 20190222, I now see this build error + Kconfig warnings:
> 
> (this is on i386; randconfig file is attached)
> 
> WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MFD_CROS_EC [=n]
>   Selected by [y]:
>   - SND_SOC_SDM845 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=y]


This error seems to be introduced by following commit.

commit 74c6ecf4194ebed285b29964a950e0cd7414fe19
Author: Cheng-Yi Chiang <cychiang@xxxxxxxxxxxx>
Date:   Mon Feb 18 12:18:19 2019 +0800

    ASoC: qcom: Kconfig: select dmic for sdm845

    sdm845 uses dmic on EC so it should select CROS_EC_CODEC.

    Signed-off-by: Cheng-Yi Chiang <cychiang@xxxxxxxxxxxx>
    Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

The problem is that this commit selects CROS_EC_CODEC but the CROS_EC_CODEC
depends on MFD_CROS_EC which is not selected.

A question for Cheng-Yi, I suppose that the answer is yes but worth ask because
I don't know about this device. Is the sdm845 a chromebook with and embedded
controller right?

Thanks,
Enric

> 
> ld: sound/soc/codecs/cros_ec_codec.o: in function `ec_command_no_resp':
> cros_ec_codec.c:(.text+0x50): undefined reference to `cros_ec_cmd_xfer_status'
> ld: sound/soc/codecs/cros_ec_codec.o: in function `mic_gain_get':
> cros_ec_codec.c:(.text+0x5a8): undefined reference to `cros_ec_cmd_xfer_status'
> 
> 
>