Re: [PATCH] au0828: minor fix to a misleading comment in _close()

[shuah]

On 2/22/19 6:44 PM, Niklas SÃderlund wrote:
> Hi Shuah,
>
> Thanks for your patch.
>
> On 2019-02-22 10:45:59 -0700, Shuah Khan wrote:
> > Fix misleading comment in _close()
> >
> > Signed-off-by: Shuah Khan <shuah@xxxxxxxxxx>
> > ---
> >   drivers/media/usb/au0828/au0828-video.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> > index 7876c897cc1d..08f566006a1f 100644
> > --- a/drivers/media/usb/au0828/au0828-video.c
> > +++ b/drivers/media/usb/au0828/au0828-video.c
> > @@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
> >   		 * so the s_power callback are silently ignored.
> >   		 * So, the current logic here does the following:
> >   		 * Disable (put tuner to sleep) when
> > -		 * - ALSA and DVB aren't not streaming;
> > +		 * - ALSA and DVB aren't streaming;
>
> Nit-picking, as you are modifying the line anyhow I would s/;/./
> With or without this changed,

Thanks. I didn't notice that one. I might as fix it. Will send v2.

> Reviewed-by: Niklas SÃderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

thanks,
-- Shuah