Re: [PATCH 02/15] perf script python: add Python3 support to check-perf-trace.py
From: Tony Jones
Date: Mon Feb 25 2019 - 13:05:54 EST
On 2/25/19 6:05 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 22, 2019 at 03:06:06PM -0800, Tony Jones escreveu:
>> Support both Python 2 and Python 3 in the check-perf-trace.py script.
>>
>> There may be differences in the ordering of output lines due to
>> differences in dictionary ordering etc. However the format within lines
>> should be unchanged.
>>
>> Also correct inconsistent indentation which was being flagged by Python3.
>
> When we have "Also" in a patch, usually it need to be split :-)
The indentation changes were required for Python3. So I viewed them as part of the change
to support Python3 ;-) However, splitting them is no problem. I'll resubmit.