Re: [PATCH v7 0/9] vfio/mdev: IOMMU aware mediated device

[Joerg Roedel]

On Fri, Feb 22, 2019 at 10:19:18AM +0800, Lu Baolu wrote:
> Lu Baolu (9):
>   iommu: Add APIs for multiple domains per device
>   iommu/vt-d: Move enable pasid out of CONFIG_INTEL_IOMMU_SVM
>   iommu/vt-d: Add per-device IOMMU feature ops entries
>   iommu/vt-d: Move common code out of iommu_attch_device()
>   iommu/vt-d: Aux-domain specific domain attach/detach
>   iommu/vt-d: Return ID associated with an auxiliary domain
>   vfio/mdev: Add iommu related member in mdev_device
>   vfio/type1: Add domain at(de)taching group helpers
>   vfio/type1: Handle different mdev isolation type

This looks mostly good to me from an IOMMU point of view. I have some
ideas for improving it further, but that can be left for later work. For
example, I wonder if it makes sense to track the enabled/disabled state
for features in core iommu code to safe the call-backs into the
iommu-drivers for the is_enabled checks.

When Alex Acks the vfio changes I am inclined to merge this for v5.1.

Regards,

	Joerg