Re: [PATCH v2 08/12] ARM: davinci: dm355: switch to using the clocksource driver

[Bartosz Golaszewski]

pt., 8 lut 2019 o 13:34 Sekhar Nori <nsekhar@xxxxxx> napisaÅ(a):
>
> On 04/02/19 10:47 PM, Bartosz Golaszewski wrote:
> > -/*
> > - * T0_BOT: Timer 0, bottom:  clockevent source for hrtimers
> > - * T0_TOP: Timer 0, top   :  clocksource for generic timekeeping
> > - * T1_BOT: Timer 1, bottom:  (used by DSP in TI DSPLink code)
> > - * T1_TOP: Timer 1, top   :  <unused>
>
> Documenting this timer division is important because DSP usage and
> unused timers are not immediately clear from kernel code alone. Can you
> retain these comments in all patches of this series (I guess T0_BOT etc.
> terminology is changed, so feel free to adjust the comment text).
>
> > - */
> > -static struct davinci_timer_info dm355_timer_info = {
> > -     .timers         = davinci_timer_instance,
> > -     .clockevent_id  = T0_BOT,
> > -     .clocksource_id = T0_TOP,
> > +static const struct davinci_timer_cfg dm355_timer_cfg = {
> > +     .reg = {
> > +             .start          = DAVINCI_TIMER0_BASE,
> > +             .end            = DAVINCI_TIMER0_BASE + SZ_4K,
>
> Here and other places too, SZ_4K - 1
>
> Thanks,
> Sekhar

I used appropriate DEFINE_RES_x() macros instead.

Bart