Re: [PATCH 3/3] Bluetooth: hci_qca: Add delay after power-off pulse

[Balakrishna Godavarthi]

On 2019-02-26 05:19, Matthias Kaehlcke wrote:
> During initialization the power-on pulse is currently sent inmediately
> after the prior power-off pulse. With this initialization often fails
> at boot time:
>
> [   15.205224] Bluetooth: hci0: setting up wcn3990
> [   17.341062] Bluetooth: hci0: command 0xfc00 tx timeout
> [   22.101453] ERROR: Bluetooth initialization failed
> [   25.337740] Bluetooth: hci0: Reading QCA version information failed 
> (-110)
>
> After a power-off pulse wait 10ms to give the controller time to power
> off.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
>  drivers/bluetooth/hci_qca.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index eacc108c422d0..c89c1ed87ffe9 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1036,8 +1036,11 @@ static int qca_send_power_pulse(struct hci_uart
> *hu, bool on)
>  	usleep_range(100, 200);
>  	hci_uart_set_flow_control(hu, false);
>
> +	/* Give to controller time to boot/shutdown */
>  	if (on)
>  		msleep(100);
> +	else
> +		msleep(10);
>
>  	return 0;
>  }

Reviewed-by: Balakrishna Godavarthi <bgodavar@xxxxxxxxxxxxxx>

--
Regards
Balakrishna.