Re: [PATCH v3 0/5] Enable wm8524 on i.MX8MQ

[Fabio Estevam]

Hi Daniel,

On Tue, Feb 26, 2019 at 4:08 AM Daniel Baluta <daniel.baluta@xxxxxxx> wrote:
>
> On i.MX8MQ we can start the party using the wm8524 codec
> which gets it's data through the SAI2 interface.
>
> In order to make it work this patch series enables the SDMA nodes,
> sets the correct pinctrl configuration and uses the simple card
> machine driver to put everything together.
>
> Changes since v2:
>         - s/QM/MQ after Chris comments
>
> Changes since v1:
>         - added cover letter
>         - remove "fsl,imx8mq-sdma" compatible for sdma.

Why? It is good practice to add the new compatible entry.

In case we find out a need for a fix that only affects imx8mq in the
future we can do that by using the specific compatible and no dts
change will be needed.

>
> Daniel Baluta (5):
>   arm64: dts: imx8mq: Add SDMA nodes
>   arm64: dts: imx8mq: Add SAI2 node
>   arm64: dts: imx8mq: Add SAI pinctrl configuration
>   arm64: dts: imx8mq: Enable SAI2 for wm8524 codec
>   arm64: dts: imx8mq: Enable wm8524 codec

I would suggest making the last three patches as a single one.

Also, please make the Subject as: arm64: dts: imx8mq-evk when a patch
is specific to the imx8mq-evk dts.