Re: [PATCH 2/2] regulator: cpcap: Constify omap4_regulators and xoom_regulators

[Sebastian Reichel]

Hi,

On Tue, Feb 26, 2019 at 01:52:30PM +0800, Axel Lin wrote:
> They should never change, make them const.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

-- Sebastian

>  drivers/regulator/cpcap-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/cpcap-regulator.c b/drivers/regulator/cpcap-regulator.c
> index c15ced1b5968..e7dab5c4d1d1 100644
> --- a/drivers/regulator/cpcap-regulator.c
> +++ b/drivers/regulator/cpcap-regulator.c
> @@ -334,7 +334,7 @@ static const unsigned int vaudio_val_tbl[] = { 0, 2775000, };
>   * SW1 to SW4 and SW6 seems to be unused for mapphone. Note that VSIM and
>   * VSIMCARD have a shared resource assignment bit.
>   */
> -static struct cpcap_regulator omap4_regulators[] = {
> +static const struct cpcap_regulator omap4_regulators[] = {
>  	CPCAP_REG(SW1, CPCAP_REG_S1C1, CPCAP_REG_ASSIGN2,
>  		  CPCAP_BIT_SW1_SEL, unknown_val_tbl,
>  		  0, 0, 0, 0, 0),
> @@ -410,7 +410,7 @@ static struct cpcap_regulator omap4_regulators[] = {
>  	{ /* sentinel */ },
>  };
>  
> -static struct cpcap_regulator xoom_regulators[] = {
> +static const struct cpcap_regulator xoom_regulators[] = {
>  	CPCAP_REG(SW1, CPCAP_REG_S1C1, CPCAP_REG_ASSIGN2,
>  		  CPCAP_BIT_SW1_SEL, unknown_val_tbl,
>  		  0, 0, 0, 0, 0),
> -- 
> 2.17.1
>

Attachment: signature.asc
Description: PGP signature