Re: [PATCH] watchdog: sc1200: Mark expected switch fall-through

[Gustavo A. R. Silva]

On 2/18/19 10:08 AM, Guenter Roeck wrote:
> On 2/14/19 12:20 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/watchdog/sc1200wdt.c: In function âsc1200wdt_ioctlâ:
>> drivers/watchdog/sc1200wdt.c:241:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> ÂÂÂ sc1200wdt_write_data(WDTO, timeout);
>> ÂÂÂ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/watchdog/sc1200wdt.c:244:2: note: here
>> ÂÂ case WDIOC_GETTIMEOUT:
>> ÂÂ ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 

Thank you, Guenter.


Friendly ping:

Who can take this?

Thanks
--
Gustavo

>> ---
>> Â drivers/watchdog/sc1200wdt.c | 2 +-
>> Â 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/sc1200wdt.c b/drivers/watchdog/sc1200wdt.c
>> index 8e4e2fc13f87..e035a4d4b299 100644
>> --- a/drivers/watchdog/sc1200wdt.c
>> +++ b/drivers/watchdog/sc1200wdt.c
>> @@ -239,7 +239,7 @@ static long sc1200wdt_ioctl(struct file *file, unsigned int cmd,
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ return -EINVAL;
>> ÂÂÂÂÂÂÂÂÂ timeout = new_timeout;
>> ÂÂÂÂÂÂÂÂÂ sc1200wdt_write_data(WDTO, timeout);
>> -ÂÂÂÂÂÂÂ /* fall through and return the new timeout */
>> +ÂÂÂÂÂÂÂ /* fall through - and return the new timeout */
>> Â ÂÂÂÂÂ case WDIOC_GETTIMEOUT:
>> ÂÂÂÂÂÂÂÂÂ return put_user(timeout * 60, p);
>>
>