Re: [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors

[Oded Gabbay]

On Tue, Feb 26, 2019 at 6:42 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Several places in the habanalabs driver use gen_alloc functions,
> so select GENERIC_ALLOCATOR to make those functions available.
>
> Fixes these build errors:
>
> ERROR: "gen_pool_alloc" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_add_virt" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_destroy" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_create" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_free" [drivers/misc/habanalabs/habanalabs.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Oded Gabbay <oded.gabbay@xxxxxxxxx>
> ---
>  drivers/misc/habanalabs/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20190226.orig/drivers/misc/habanalabs/Kconfig
> +++ linux-next-20190226/drivers/misc/habanalabs/Kconfig
> @@ -6,6 +6,7 @@ config HABANA_AI
>         tristate "HabanaAI accelerators (habanalabs)"
>         depends on PCI
>         select FRAME_VECTOR
> +       select GENERIC_ALLOCATOR
>         help
>           Enables PCIe card driver for Habana's AI Processors (AIP) that are
>           designed to accelerate Deep Learning inference and training workloads.
>
>

Thanks for catching that.
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>