Re: [PATCH 0/5] PCI: dwc: support remove
From: Jisheng Zhang
Date: Wed Feb 27 2019 - 01:48:14 EST
On Tue, 26 Feb 2019 15:11:03 -0600 Bjorn Helgaas wrote:
>
>
> On Tue, Feb 26, 2019 at 5:55 AM Jisheng Zhang
> <Jisheng.Zhang@xxxxxxxxxxxxx> wrote:
> >
> > Currently, the PCI dwc host users don't support the remove, but nothing
> > prevent us from supporting it. To achieve this goal, we need to ensure
> > we can do necessary clean up work.
> >
> > Jisheng Zhang (5):
> > PCI: dwc: fix dw_pcie_free_msi() if msi_irq is invalid
> > PCI: dwc: free the page for MSI irq in dw_pcie_free_msi()
> > PCI: dwc: free msi in the error code path of dw_pcie_host_init()
> > PCI: dwc: use devm_pci_alloc_host_bridge() to simplify the code
> > PCI: dwc: save root bus for driver remove
>
> If you post a v2 of this series, please:
>
> Capitalize the first word of each subject, e.g., "PCI: dwc: Fix
> dw_pcie_free_msi() if msi_irq is invalid"
> s/irq/IRQ/
> s/msi/MSI/
Thanks for the review. Will do when post a v2. I'm still trying to
collect more code review comments.
Thanks