Re: [PATCH v2] soc: imx: Add generic i.MX8 SoC driver

[Leonard Crestez]

On Wed, 2019-02-27 at 08:41 +0000, Abel Vesa wrote:
> On 19-02-26 13:34:52, Leonard Crestez wrote:
> > On Tue, 2019-02-26 at 10:53 +0000, Abel Vesa wrote:
> > > Add generic i.MX8 SoC driver along with the i.MX8MQ SoC specific code.
> > > For now, only i.MX8MQ revision B1 is supported. For any other, i.MX8MQ
> > > revision it will print 'unknown'.
> > > 
> > > +	np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-ocotp");
> > > +	if (!np)
> > > +		goto out;
> > > +
> > > +	ocotp_base = of_iomap(np, 0);
> > > +	WARN_ON(!ocotp_base);
> > > +
> > > +	magic = readl_relaxed(ocotp_base + IMX8MQ_SW_INFO_B1);
> > > +	if (magic == IMX8MQ_SW_MAGIC_B1)
> > > +		rev = REV_B1;
> > 
> > Turns out that imx8mq version determination is uniquely messy. I think
> > we should try to print the revision number even for older chips so that
> > we know how old they are, but this code can be enhanced in later
> > patches.
> 
> Fair enough. I believe we should stick to B1 only for now though.

Yes, people who want their old SOC revisions to be be detected can
submit later patches.