Re: [PATCH v3 20/34] sparc: mm: Add p?d_large() definitions

From: David Miller
Date: Wed Feb 27 2019 - 13:38:42 EST


From: Steven Price <steven.price@xxxxxxx>
Date: Wed, 27 Feb 2019 17:05:54 +0000

> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_large() functions/macros.
>
> For sparc, we don't support large pages, so add stubs returning 0.
>
> CC: "David S. Miller" <davem@xxxxxxxxxxxxx>
> CC: sparclinux@xxxxxxxxxxxxxxx
> Signed-off-by: Steven Price <steven.price@xxxxxxx>

Sparc does support large pages on 64-bit, just not at this level. It
would be nice if the commit message was made more accurate. Other than
that:

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>