Re: [PATCH] appletalk: Fix use-after-free in atalk_proc_exit

[YueHaibing]

On 2019/2/28 2:14, David Miller wrote:
> From: Yue Haibing <yuehaibing@xxxxxxxxxx>
> Date: Wed, 27 Feb 2019 22:59:00 +0800
> 
>> @@ -1925,7 +1925,10 @@ static int __init atalk_init(void)
>>  
>>  	register_netdevice_notifier(&ddp_notifier);
>>  	aarp_proto_init();
>> -	atalk_proc_init();
>> +	rc = atalk_proc_init();
>> +	if (rc)
>> +		goto out;
>> +
>>  	atalk_register_sysctl();
>>  out:
> 
> This leaves the netdevice notifier registered etc.  You need to add a proper
> error cleanup code path.

Oh, yes, I will do it.

Thanks!

> 
> .
>